feat: Sort IESG and IAB Statements Pages with Active Statements at the Top #9198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ?
Additional details and impacted files@@ Coverage Diff @@
## main #9198 +/- ##
==========================================
+ Coverage 88.72% 88.76% +0.03%
==========================================
Files 321 320 -1
Lines 41851 41648 -203
==========================================
- Hits 37134 36967 -167
+ Misses 4717 4681 -36 ? View full report in Codecov by Sentry. ?? New features to boost your workflow:
|
rjsparks
previously approved these changes
Jul 21, 2025
|
It's unlikely some other status would come in alphabetically lower than active, but if it ever did, we could build a sort that deals with it. |
|
This is also my thinking, let's not overdo it right now. |
rjsparks
approved these changes
Jul 22, 2025
rjsparks
approved these changes
Jul 22, 2025
jennifer-richards
approved these changes
Jul 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #9058
Remaining caveat: it is sorted by statement.state but currently only "active" and "replaced" whose alphabetical order matches the requested feature. If other states are introduced (e.g., "historic"), then the order wont't be so perfect.